Skip to content

diagnostics: add hint to message, if present #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

diagnostics: add hint to message, if present #230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6073ac2
diagnostics: add hint to message, if present
kubukoz Jul 24, 2025
96921ca
Update src/main/java/software/amazon/smithy/lsp/diagnostics/SmithyDia…
kubukoz Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/main/java/software/amazon/smithy/lsp/diagnostics/SmithyDiagnostics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,20 @@ default Diagnostic toDiagnostic(ValidationEvent event) {
default -> DiagnosticSeverity.Hint;
};
var diagnosticRange = getDiagnosticRange(event);
var message = event.getId() + ": " + event.getMessage();
var message = getMessage(event);
return new Diagnostic(diagnosticRange, message, diagnosticSeverity, "Smithy");
}

String HINT_PREFIX = System.lineSeparator() + System.lineSeparator() + "Hint: ";

private static String getMessage(ValidationEvent event) {
var hint = event.getHint().orElse(null);
if (hint == null) {
return event.getId() + ": " + event.getMessage();
}

return event.getId() + ": " + event.getMessage() + HINT_PREFIX + hint;
}
}

private record Simple() implements EventToDiagnostic {}
Expand Down
Loading