Conversation
dlm6693
force-pushed
the
identity-auth
branch
from
c26fa14 to
d222100
Compare
dlm6693
commented
Dec 19, 2022
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
JordonPhillips
previously requested changes
Dec 20, 2022
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
nateprewitt
reviewed
Dec 20, 2022
Contributor
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
I left some target comments but it seems like we've taken a lot of the general purpose signing interface and put it directly into the AWS SDK.
If we can avoid customers having to reimplement all of this themselves, we should try to keep things like IdentityResolver and HttpSigner in smithy_python since they're not AWS specific. We should also try to avoid using "SDK" in most of these contexts and use the more general term "client".
python-packages/aws-smithy-python/aws_smithy_python/exceptions.py
Outdated
Show resolved
Hide resolved
python-packages/smithy-python/smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/smithy-python/smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
dlm6693
commented
Dec 21, 2022
python-packages/aws-smithy-python/aws_smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
dlm6693
force-pushed
the
identity-auth
branch
3 times, most recently
from
f7a3e47 to
b6fff66
Compare
nateprewitt
suggested changes
Dec 28, 2022
python-packages/aws-smithy-python/aws_smithy_python/exceptions.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/auth.py
Outdated
Show resolved
Hide resolved
python-packages/smithy-python/smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/smithy-python/smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/auth.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/auth.py
Outdated
Show resolved
Hide resolved
python-packages/aws-smithy-python/aws_smithy_python/interfaces/auth.py
Outdated
Show resolved
Hide resolved
| """Represents a way an AWS service will authenticate the customer's identity.""" | ||
|
|
||
| scheme_id: str | ||
| """A unique identifier for the authentication scheme (v4, v4a, none, bearer, etc.).""" |
Contributor
There was a problem hiding this comment.
Do we have this pattern elsewhere in the codebase currently? If so, we should consider fixing this. We shouldn't be using multiple docstrings like this within the class definition generally. It's also odd they follow what they're discussing. Is there a reason for the current layout?
We can either include this info in a single docstring, or use line comments above the variable to add any specific information.
Contributor
Author
There was a problem hiding this comment.
Yes this is the current style being used. I copied what was in retries and http. I can update to comments above the variable as I think they do provide helpful context.
cc @jonemo
python-packages/aws-smithy-python/aws_smithy_python/interfaces/auth.py
Outdated
Show resolved
Hide resolved
added 6 commits
January 3, 2023 15:37
…thon. Removed all usage of TypeVar and Generic and removed some files from gitignore.
nateprewitt
suggested changes
Jan 3, 2023
python-packages/smithy-python/smithy_python/interfaces/identity.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds several interfaces for identities and authentication. An
Identityobject represents who an AWS customer is.HttpAuthSchemerepresents a method by which the identity of a customer is authenticated. There are several other interfaces defined that are used for signing requests, resolving identities/auth schemes and configuring identity resolvers.This also includes a couple of new exception types and a few additional paths to ignore in
.gitignore.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.