Fix encoding of path in aiohttp requests #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan343
approved these changes
Mar 20, 2025
JordonPhillips
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When using a
strfor the url in aiohttp.ClientSession.request, paths will be un-uri encoded. However, when a yarl.URL is provided withencoded=Trueit will be used as is. This matches the behavior of our CRT HTTP client.yarl is an explicit dependency of aiohttp. The clientSession we call request on takes a "strOrUrl" and then if its a str, uses yarl.URL to build it - so by doing it explicitly, we're able to control whether the encoding is done or not
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.