Skip to content

Fix encoding of path in aiohttp requests #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Fix encoding of path in aiohttp requests #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions packages/smithy-http/src/smithy_http/aio/aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
from copy import copy, deepcopy
from itertools import chain
from typing import TYPE_CHECKING, Any
from urllib.parse import parse_qs, urlunparse
from urllib.parse import parse_qs

import yarl

if TYPE_CHECKING:
# pyright doesn't like optional imports. This is reasonable because if we use these
Expand Down Expand Up @@ -97,10 +99,17 @@ async def send(
) as resp:
return await self._marshal_response(resp)

def _serialize_uri_without_query(self, uri: URI) -> str:
def _serialize_uri_without_query(self, uri: URI) -> yarl.URL:
"""Serialize all parts of the URI up to and including the path."""
components = (uri.scheme, uri.netloc, uri.path or "", "", "", "")
return urlunparse(components)
return yarl.URL.build(
scheme=uri.scheme or "",
host=uri.host,
port=uri.port,
user=uri.username,
password=uri.password,
path=uri.path or "",
encoded=True,
)

async def _marshal_response(
self, aiohttp_resp: "aiohttp.ClientResponse"
Expand Down