Skip to content

Conversation

@nateprewitt
Copy link
Contributor

Description of changes:
This PR adds an initial changelog and moves aws-event-streams to smithy-aws-event-streams under the Smithy domain to make it's relationship clearer.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nateprewitt nateprewitt requested a review from a team as a code owner March 27, 2025 20:34
@nateprewitt nateprewitt marked this pull request as draft March 27, 2025 20:34
alextwoods
alextwoods previously approved these changes Mar 27, 2025
@@ -0,0 +1,4 @@
## Unreleased
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we should add similar changes.md to other packages and move these to 0.0.1 once released?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, was working on that and then started the rename. I'll have 2 more PRs with changes and then finalizing release commits.

@nateprewitt nateprewitt force-pushed the smithy_namespace_es branch from 5469557 to 9da5bca Compare March 27, 2025 20:51
@nateprewitt nateprewitt marked this pull request as ready for review March 27, 2025 20:58
@nateprewitt nateprewitt changed the title [Draft] Move aws_event_stream to smithy_aws_event_stream Move aws_event_stream to smithy_aws_event_stream Mar 27, 2025
@jonathan343
Copy link
Contributor

Why is the patent directory plural (smithy-aws-event-streams) and the child directory singular (smithy_aws_event_stream)? I would expect for them to match

@nateprewitt nateprewitt force-pushed the smithy_namespace_es branch from 9da5bca to 8a1af26 Compare March 31, 2025 18:20
Copy link
Contributor

@jonathan343 jonathan343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@nateprewitt nateprewitt merged commit 3d205be into develop Mar 31, 2025
2 checks passed
@nateprewitt nateprewitt deleted the smithy_namespace_es branch March 31, 2025 18:25
SamRemis pushed a commit to SamRemis/smithy-python that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants