Skip to content

Fix incorrect interceptor chain calls #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Fix incorrect interceptor chain calls #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a88c731
Fix incorrect interceptor chain calls
nateprewitt Apr 8, 2025
71e24f4
Add changelog
nateprewitt Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/smithy-core/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

## Unreleased

* <Add new items here>
### Bugfixes

* Fixed incorrect interceptors for `modify_before_signing` and `modify_before_transmit`.

## v0.0.1

Expand Down
4 changes: 2 additions & 2 deletions packages/smithy-core/src/smithy_core/interceptors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ def read_before_attempt(self, context: RequestContext[Any, Any]) -> None:
def modify_before_signing(self, context: RequestContext[Any, Any]) -> Any:
transport_request = context.transport_request
for interceptor in self._chain:
transport_request = interceptor.modify_before_retry_loop(context)
transport_request = interceptor.modify_before_signing(context)
return transport_request

def read_before_signing(self, context: RequestContext[Any, Any]) -> None:
Expand All @@ -591,7 +591,7 @@ def read_after_signing(self, context: RequestContext[Any, Any]) -> None:
def modify_before_transmit(self, context: RequestContext[Any, Any]) -> Any:
transport_request = context.transport_request
for interceptor in self._chain:
transport_request = interceptor.modify_before_retry_loop(context)
transport_request = interceptor.modify_before_transmit(context)
return transport_request

def read_before_transmit(self, context: RequestContext[Any, Any]) -> None:
Expand Down