Pagination#289
Conversation
jterapin
left a comment
jterapin
left a comment
There was a problem hiding this comment.
Lookin' good. I like that you push the filter_traits to the view shapes. That really streamlines the "View" side of things.
| def initialize(options = {}) | ||
| @id = options[:id] | ||
| @traits = options[:traits] || {} | ||
| @metadata = {} |
There was a problem hiding this comment.
We previously used this attribute in the ShapeRef class from V3.
I like that we have this around for flexibility but hard to keep track of all metadata usages over time (actually, is there a way to see all metadata usages in V3? So far, I just search for ref[: to see if there's usage but that's making an assumption that ref variable is used).
Any ideas to elevate this?
There was a problem hiding this comment.
We have this in v3 on shape too, not just shaperef. Inspect on shape will print out metadata. What specifically is the concern you have about finding usage of it? I think it's a dumping ground for anything - any plugin/handler could add context to a shape like from a custom runtime trait or something.
Co-authored-by: Juli Tera <57973151+jterapin@users.noreply.github.com>
2 participants
Support the paginated trait by using methods on Output for iteration.