Conversation
added 2 commits
May 2, 2025 18:54
jterapin
reviewed
May 3, 2025
Contributor
jterapin
left a comment
jterapin
left a comment
There was a problem hiding this comment.
I just reviewed the ShapeRef section - I have additional thoughts but I will share them offline.
added 2 commits
May 4, 2025 13:07
mullermp
commented
May 4, 2025
| Timestamp: Smithy::Schema::Shapes::TimestampShape | ||
| Union: Smithy::Schema::Shapes::UnionShape | ||
| BigDecimal: Smithy::Schema::Shapes::bigDecimal | ||
| BigInteger: Smithy::Schema::Shapes::bigInteger |
Contributor
Author
There was a problem hiding this comment.
I need to fix these.
jterapin
approved these changes
May 5, 2025
Comment on lines
+45
to
+46
| # @return [String, nil] | ||
| attr_reader :location_name |
Contributor
There was a problem hiding this comment.
Could we add a description here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove MemberShape as a concept and use ShapeRef which contains the shape target and any traits it has. Some "container" seems to be necessary for codec traversal (we will wrap them in shape ref if not provided) - and operation input/output/errors aren't technically member shapes but rather references (because they have target shapes in the model). Currently, the visitor patterns are very awkward, for traits that must be checked at the member layer and then the shape layer (for example timestampFormat). This also removes some awkward accessors on shapes like "member by location name"