feat: Implement GET presigner for synthesizespeech #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooj2
force-pushed
the
feat/pollysep
branch
from
8a2c307 to
8eb633c
Compare
kneekey23
reviewed
Sep 27, 2021
Packages/ClientRuntime/Sources/PrimitiveTypeExtensions/URL+Extension.swift
Show resolved
Hide resolved
kneekey23
reviewed
Sep 27, 2021
|
|
||
| private fun resolveHttpMethod(op: OperationShape): String { | ||
| val httpMethod = when (executionContext) { | ||
| MiddlewareRenderableExecutionContext.PRESIGNER_POLLY_GET_REQUEST -> { |
Contributor
There was a problem hiding this comment.
is this maybe a case for a section writer? feels weird to have something so aws specific in smithy-swift since we know well have to refactor this out at some point
wooj2
force-pushed
the
feat/pollysep
branch
from
da3e4a3 to
704eebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding:
awslabs/aws-sdk-swift#407
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.