fix: remove duplicated middlewares #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooj2
reviewed
Jan 27, 2022
There was a problem hiding this comment.
Ideally, this could have been split up in to 3 different prs -- one for body, one for headers, and one for query -- if we had done that, we could have incrementally tracked progress and/or have the ability to back things out. you can decide if you wanna keep it as-is or separated.
...main/kotlin/software/amazon/smithy/swift/codegen/integration/HttpBindingProtocolGenerator.kt
Outdated
Show resolved
Hide resolved
...ftware/amazon/smithy/swift/codegen/integration/HttpProtocolBodyMiddlewareGeneratorFactory.kt
Show resolved
Hide resolved
...software/amazon/smithy/swift/codegen/integration/middlewares/OperationInputBodyMiddleware.kt
Outdated
Show resolved
Hide resolved
...software/amazon/smithy/swift/codegen/integration/middlewares/OperationInputBodyMiddleware.kt
Outdated
Show resolved
Hide resolved
...oftware/amazon/smithy/swift/codegen/integration/middlewares/handlers/HttpHeaderMiddleware.kt
Outdated
Show resolved
Hide resolved
...oftware/amazon/smithy/swift/codegen/integration/middlewares/handlers/HttpHeaderMiddleware.kt
Outdated
Show resolved
Hide resolved
...ware/amazon/smithy/swift/codegen/integration/middlewares/handlers/HttpQueryItemMiddleware.kt
Outdated
Show resolved
Hide resolved
wooj2
reviewed
Jan 27, 2022
Packages/ClientRuntime/Sources/Networking/Http/Middlewares/SerializableBodyMiddleware.swift
Outdated
Show resolved
Hide resolved
wooj2
reviewed
Jan 28, 2022
...software/amazon/smithy/swift/codegen/integration/middlewares/OperationInputBodyMiddleware.kt
Outdated
Show resolved
Hide resolved
wooj2
approved these changes
Jan 28, 2022
| val inputShape = opIndex.getInput(op).get() | ||
|
|
||
| if (httpProtocolBodyMiddleware.shouldRenderHttpBodyMiddleware(inputShape)) { | ||
| if (MiddlewareShapeUtils.hasHttpBody(ctx.model, op) && MiddlewareShapeUtils.bodyIsHttpPayload(ctx.model, op)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR removes generated middlewares that are duplicated and not needed in an effort to decrease binary size of generated sdks.
Corresponding PR: awslabs/aws-sdk-swift#532
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.