Enable passing dynamic parameters to RuntimeClientPlugin functions #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
reviewed
Jun 9, 2021
...src/main/java/software/amazon/smithy/typescript/codegen/integration/RuntimeClientPlugin.java
Outdated
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/typescript/codegen/integration/RuntimeClientPlugin.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/ServiceGenerator.java
Outdated
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/typescript/codegen/integration/RuntimeClientPlugin.java
Outdated
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/typescript/codegen/integration/RuntimeClientPlugin.java
Outdated
Show resolved
Hide resolved
kstich
requested changes
Jun 15, 2021
...src/main/java/software/amazon/smithy/typescript/codegen/integration/RuntimeClientPlugin.java
Outdated
Show resolved
Hide resolved
...typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenUtils.java
Outdated
Show resolved
Hide resolved
This is a requirement for advanced use cases of Endpoint Discovery logic. Currently, only Symbols and strings are generated for parameters. In future, boolean and Map<String, String> support would be added.
trivikr
force-pushed
the
runtime-plugin-function-supplier
branch
from
2cee533 to
3c6255b
Compare
AllanZhengYP
approved these changes
Jun 24, 2021
kstich
approved these changes
Jun 25, 2021
This was referenced Jun 25, 2021
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes: #352
Description of changes:
This is a requirement for advanced use cases of Endpoint Discovery logic.
Currently, only Symbols and strings are generated for parameters. In future,
boolean and Map<String, String> support would be added.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.