Fix serialization of REST-JSON requests when the endpoint has a path #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosar
approved these changes
Jun 25, 2021
| + " context: $L\n" | ||
| + "): Promise<$T> => {", "}", methodName, inputType, contextType, requestType, () -> { | ||
|
|
||
| // Get the hostname, port, and scheme from client's resolved endpoint. Then construct the request from |
| // Always write the bound path, but only the actual segments. | ||
| writer.write("let resolvedPath = $S;", "/" + trait.getUri().getSegments().stream() | ||
| writer.write("let resolvedPath = `$L` + $S;", | ||
| "${basePath?.endsWith('/') ? basePath.slice(0, -1) : (basePath || '')}", |
Contributor
There was a problem hiding this comment.
Is there a unit test to add tests for these cases?
Contributor
Author
There was a problem hiding this comment.
Not that I can see, no.
Contributor
Author
There was a problem hiding this comment.
Looks like protocol tests let you specify a custom endpoint, so it should be testable there.
Contributor
Author
There was a problem hiding this comment.
Endpoints can have paths (notable example: API Gateway REST APIs without a custom domain name), and serialization of REST-JSON requests was ignoring these paths even though it's available from the endpoint provider.
adamthom-amzn
force-pushed
the
fix-endpoint-paths
branch
from
134eb8f to
69ca9e7
Compare
adamthom-amzn
force-pushed
the
fix-endpoint-paths
branch
from
65ac47f to
02dc06b
Compare
gosar
approved these changes
Jun 25, 2021
JordonPhillips
approved these changes
Jul 2, 2021
Contributor
|
Can you post the PR with changes to js sdk v3? |
Contributor
|
I'm working on getting the pr up |
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Endpoints can have paths (notable example: API Gateway REST APIs without a
custom domain name), and serialization of REST-JSON requests was ignoring
these paths even though it's available from the endpoint provider.
Tested this locally against a APIGateway REST API with SigV4 that was broken without it.
This will also impact JS client generation for every REST-JSON service. We have a couple such changes out right now, was going to submit a regeneration PR when all of those land.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.