Use base64 en/decoder from context in bindings #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the http binding generator to use the context's http encoder / decoder for base64 rather than relying on Buffer's implementation. We do still use Buffer for converting between utf8 and Uint8Array though.
adamthom-amzn
approved these changes
Sep 14, 2021
trivikr
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the http binding generator to use the context's http encoder / decoder for base64 rather than relying on Buffer's implementation. We do still use Buffer for converting between utf8 and Uint8Array though.
Codegen pr: aws/aws-sdk-js-v3#2786
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.