-
Notifications
You must be signed in to change notification settings - Fork 241
Event stream protocol tests #2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e07f711 to
022d9a1
Compare
| appliesTo: "client" | ||
| } | ||
| { | ||
| id: "MalformedEventTypeOutput" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably there are some below, but if there aren't, I'd be good to test malformed input, e.g, invalid type (boolean given where string expected), and similar.
This updates event stream protocol tests to use text blocks for the JSON bodies to make them easier to read.
022d9a1 to
70de99a
Compare
|
EDIT: I changed my mind on this. The tests that don't have base64 representing bytes should. That can't be changed now, but we don't have to introduce more of this. One addition that was made to the spec was to allow including the entire event bytes. These tests were written before that, so they aren't there. But I can add them. It's not really useful for serialization comparisons, but it is useful for deserialization tests, so I can go ahead and add them. |
This adds blob support to NodeMapper, serializing to and from base64 encoded string nodes.
This adds a trait for event stream protocol tests as well as an initial batch of tests for restJson1. These can be used to assert an implementation is compliant with the protocol.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.