Quote unresolvable idRef values in IDL serializer#3038
Merged
Conversation
Contributor
|
This pull request does not contain a staged changelog entry. To create one, use the Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See |
SmithyIdlModelSerializer rendered all @idref string values as bare shape IDs regardless of whether the referenced shape existed in the model. When @idref has failWhenMissing set to false (the default), the target shape may not exist, and the bare identifier produced invalid IDL that failed to re-parse. The serializer now checks whether the shape ID resolves to a shape in the model before choosing the bare format. Unresolvable values fall through to quoted string rendering, which is always valid IDL and preserves round-trip fidelity.
kstich
force-pushed
the
dev/kstich/idref-quote-fix
branch
from
b468f28 to
b8e3869
Compare
JordonPhillips
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SmithyIdlModelSerializer rendered all @idref string values as bare shape IDs regardless of whether the referenced shape existed in the model. When @idref has failWhenMissing set to false (the default), the target shape may not exist, and the bare identifier produced invalid IDL that failed to re-parse.
The serializer now checks whether the shape ID resolves to a shape in the model before choosing the bare format. Unresolvable values fall through to quoted string rendering, which is always valid IDL and preserves round-trip fidelity.
Resolves: #2494
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.