Fix transitive dependency resolution for --use modules#5
Merged
Conversation
When --use MODULE is specified, smlt now scans the module's .ll file for declare statements and seeds them into the fixpoint resolver. This enables automatic discovery of transitive dependencies (e.g. --use test auto-resolves buf and str if test declares their symbols). Also removes a stale _smlt_extract_declares call that was immediately overwritten by the correct extraction into a temp buffer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
smintz
force-pushed
the
fix-transitive-deps
branch
from
fc022eb to
f816da6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--use MODULEis specified,_smlt_resolve_modulesnow scans each seed module's.llfile fordeclarestatements and seeds them into the fixpoint symbol set--usemodules are now auto-resolved (e.g.--use testwhere test depends onbufandstrwill auto-resolve both)_smlt_extract_declarescall that was immediately overwritten by the correct temp-buffer extractionseed_count = 0or--no-autois usedTest plan
smlt run app.ll --use test --autoresolvesbufandstras transitive deps oftestsmlt build app.ll out --use test --no-autoonly includestest(no transitive resolution)smlt run app.ll --auto(no--use) still works as beforesmlt install apps/smlt/smlt.llself-build succeeds with no regression🤖 Generated with Claude Code