Merged
Conversation
taiki-e
approved these changes
Sep 14, 2024
Collaborator
taiki-e
left a comment
taiki-e
left a comment
There was a problem hiding this comment.
Thanks!
When I first looked at "Deprecate target_vendor" MCP I was under the impression that it might be done in such a way as to break existing Apple-related code, so I was preferring to avoid target_vendor = "apple", but from the latest discussion it seems okay.
taiki-e
approved these changes
Sep 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the future you'll probably be able to use
target_family = "darwin"instead, but for nowtarget_vendor = "apple"should suffice.