Implement AsRawFd for Poller on Redox OS#235
Merged
zeenix merged 1 commit intosmol-rs:masterfrom Apr 10, 2025
Merged
Conversation
zeenix
approved these changes
Apr 10, 2025
Member
zeenix
left a comment
zeenix
left a comment
There was a problem hiding this comment.
LGTM. I wish we had some tests for Redox. Maybe some day Github will support Redox runners. :)
Member
Hmm.. actually seems we already check the build for niche OSes like netbsd. Perhaps good idea to do that for redox too? 🤔 |
Contributor
Author
|
It should be possible, either with |
Member
|
Contributor
Author
|
Unfortunately we are in the midst of completing some large projects that can make redoxer unreliable. |
Contributor
Author
|
Can a new release be made with this change? |
Merged
Collaborator
|
Published in 3.8.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redox OS is one of the epoll platforms so I added it next to the other epoll platforms.