feat(ChunkExtractor): support publicPath override

[brkalow]

Summary

Add support for passing publicPath to ChunkExtractor. This will allow consumers to override publicPath at runtime.

Currently in our usage we are loading the stats file, manually overriding the publicPath, and then injecting that stats object into ChunkExtractor. This seems like a simple enough change that it warrants being supported out-of-the-box.

Formatted docs section: https://deploy-preview-292--loadable.netlify.com/docs/server-side-rendering/#override-statspublicpath-at-runtime

closes #269

Test plan

Added new test cases to packages/server/src/ChunkExtractor.test.js.

[ryanboswell]

This looks great, exactly what we were hoping for 👍

[gregberge]

@brkalow thank you for this PR! Could you please rebase and I will merge it.

[brkalow]

@neoziro Done, thanks!

[lauterry]

Hi

I think this is what I was looking for.

My use case is that I call chunkExtractor.getCssString on a server at runtime to gather the critical CSS and inject it in the html before sending it to the browser.

However, now, the output is incorrect therefore when getCssString tries to look for a css file, it didn't find it. Indeed, The outputPath on build time is not the same on runtime.

@neoziro Can you confirm that chunkExtractor.getCssString relies on stats.outputPath to find the css ?

If so, please publish a new release for the new feature

Thank a lot

[brkalow]

@lauterry I believe ChunkExtractor already supports passing in outputPath to solve the issue you are having. It looks like ChunkExtractor.getCssString does rely on stats.outputPath to get the filepath:

See here: https://github.com/smooth-code/loadable-components/blob/master/packages/server/src/ChunkExtractor.js#L186

[lauterry]

Thx @brkalow

You're right. I'll give it a try.

Sorry for the noise. I have confounded publicPath and outputPath

[lauterry]

@brkalow

Indeed, your proposition fixed my issue. Thx

[sourabhkheterpal]

@brkalow Hello, When you guys plan to release this to NPM ? It still gives us older version. Kindly update NPM if possible. Thanks.

[brkalow]

@sourabhkheterpal I believe this is included in @loadable/server@5.8.0 👍

[gregberge]

Yes it is!

[srigar]

@brkalow This is awesome feature what i'm looking for currently. Added public path in chunk extractor but still js(chunk files) not loading from the runtime path which provided in publicPath.
Did I missed anything here?

extractor = new ChunkExtractor({
    statsFile: path.resolve(process.cwd(), './build/loadable-stats.json'),
    publicPath: process.env.CHUNK_ASSET_PATH
});

<ChunkExtractorManager extractor={extractor}>
        {component}
 </ChunkExtractorManager>

[natterstefan]

Hi @srigar,

I have the same issue, did you find a solution yet?

Thanks for your help.