This repository was archived by the owner on Jun 20, 2022. It is now read-only.
Add scroll-lock to modals #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Package used - https://bundlephobia.com/result?p=react-remove-scroll@1.0.1, 1.6kb effective size (excluding tslib) |
Member
|
Awesome 💯!! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #25 - modals should disable body scroll to prevent issues on iOS and provide a more expected behaviour.
Together with focus lock, shadow and
aria-hiddenit makes Modal a real modal.Test plan
Just open a modal - and scroll will disappear.