Modal Dialog's "scroll lock" is incorrect

[theKashey]

Modal dialog on mounting is setting overflow:hidden directly on body, and remove it on unmount.
Don't do that :)

Problems:

1. What if you have two modals? It will "unlock" scroll after the first unmount.
2. It will hide scroll bar on windows machines, casing content to "jump"
3. It does not work for mobile safari at all 😺

https://github.com/theKashey/react-scroll-locky will do the job

[gregberge]

Thanks, same I will take a look!

The problem with two modals is easy too solve, others are trickier!

[theKashey]

Just fill the issues, and I'll help.

[theKashey]

• Add <input type="text" /> into the modal
• Open it using Safari Mobile
• Select input
• ....
• Safari would use position:absolute instead of position:fixed, and your customer will lose the modal.

[gregberge]

Hello @theKashey, yeah I know the scroll lock is still incorrect 😣. Can you help on that point?

[theKashey]

Sure. Let me just fix one theoretical issue with portals first.

[theKashey]

Solved by creating another library :)