This repository was archived by the owner on Jun 20, 2022. It is now read-only.
feat: add control option to Checkbox #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregberge
suggested changes
Jan 21, 2019
docs/components/Checkbox.mdx
Outdated
| <Playground> | ||
| <FormCheck> | ||
| <Checkbox | ||
| id="sizeCheckbox1" |
Member
There was a problem hiding this comment.
Can you update this id to make it unique in the page? Same for other ids.
Member
|
Hello @ividic, thanks for this feature! It is great, just a small issue in the documentation that make it impossible to click on a checkbox. Can you fix it? Thanks again! |
Contributor
Author
|
No problem, thanks for pointing it out! All done, fixed a small typo in the name attributes as well |
gregberge
approved these changes
Jan 22, 2019
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding
controlandvalidprops to Checkbox component to bring it inline with the Input component.Test plan
Passes linting and tests.