This repository was archived by the owner on Jun 20, 2022. It is now read-only.
Fix @smooth-ui/core-em TypeScript definitions #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjust the build step so core-em and core-sc have their own independent type definitions, and copy the shared definitions to a 'shared/index.d.ts' module.
Fixes #106
Test plan
Check out my branch, then
yarn run buildthe repo. Then run:The tsc command should exit with status 0.
I have tested this with my own application which uses emotion + TypeScript, but I haven't tested with a styled-components project yet. I'd also like to add a tsc build/test step to smooth-ui to prevent future regressions. Let me know if I should include it as part of this PR or a follow-up PR, and any other suggestions!