Skip to content

Add PR vetting checklist and link #56 from CONTRIBUTING#61

Merged
smorchj merged 1 commit intomainfrom
docs/contributing-pr-vetting
Apr 15, 2026
Merged

Add PR vetting checklist and link #56 from CONTRIBUTING#61
smorchj merged 1 commit intomainfrom
docs/contributing-pr-vetting

Conversation

@smorchj
Copy link
Copy Markdown
Owner

@smorchj smorchj commented Apr 15, 2026

Summary

Two related changes to set expectations for incoming contributors:

  1. Pre-PR section now lists running tests, linking the closed issue, and one-issue-per-PR — things we already enforce in review but haven't written down.
  2. New 'How PRs are reviewed' section explains the bar every PR has to clear: scope matches the description, tests assert what they claim, no silent regressions, no obfuscation, security PRs get a stricter read. Importantly says we don't auto-decline first-time contributors and will leave actionable review feedback rather than closing.
  3. 'Good first contributions' section now leads with Generalizability audit — what project types does Klonode fail on? #56 and links the relevant sub-issues by number, so a new contributor can go from CONTRIBUTING.md → tracking issue → sub-issue → PR in three clicks.

Test plan

Two related changes to set expectations for incoming contributors:

1. Pre-PR section now lists running tests, linking the closed issue,
   and one-issue-per-PR — things we already enforce in review but
   haven't written down.

2. New 'How PRs are reviewed' section explains the bar every PR has
   to clear: scope matches the description, tests assert what they
   claim, no silent regressions, no obfuscation, security PRs get a
   stricter read. Importantly says we don't auto-decline first-time
   contributors and will leave actionable review feedback rather than
   closing.
@smorchj smorchj merged commit ea503de into main Apr 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant