Skip to content

Wrong composer versioning (php) and php84 deprecations #136

@Buzka91

Description

@Buzka91

Hi, you got wrong PHP requirements

"php": "^7 || ~8.0 || ~8.1 || ~8.2 || ~8.3 || ~8.4",

https://github.com/smsapi/smsapi-php-client/blob/v3.0.12/composer.json#L19

Accordning to composer documentation for Tilde operator:
~8.4 is equivalent to >=8.4 <9.0.0
~8.4.0 is equivalent to >=8.4.0 <8.5.0

Also while your composer support PHP 8.4 your code is not adapted to the new version, for example:

Smsapi\Client\Feature\Sms\Bag\ScheduleSmsBag::setIdx(): Implicitly marking parameter $checkIdx as nullable is deprecated, the explicit nullable type must be used instead

Smsapi\Client\Feature\Sms\Bag\SendSmsBag::setExternalId(): Implicitly marking parameter $checkIdx as nullable is deprecated, the explicit nullable type must be used instead

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions