Skip to content

Conversation

@cmaier
Copy link
Contributor

@cmaier cmaier commented Dec 7, 2023

Added missing credit cards to validation.

How to test?

  • Integrate this branch from the SDK in a current app.
  • Add a CreditCard using e.g. PayONE.
  • Set the time of the device in the future, exceeding the valid time of the added credit card
  • The credit is deleted from the app. 🎉

Definition of Done

  • Changelog gepflegt
  • Dokumentation gepflegt
  • Alle Anforderung des Issues sind erfüllt
  • Selbst greviewed (aka Self-Reviews (eng))
  • Review mit Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified getestet? (aka. Release Build)
  • Environements beachtet (Production/Staging)
  • Unterstützte Sprachen sind getestet
  • Light-/Dark-Mode getestet
  • Edge-Cases getestet
  • Android API Levels wurden berücksichtigt (minSdk?)

Testing

  • Tests geschrieben (aka Unit-Tests, Integration-Tests)
  • Tests lokal laufen gelassen

@cmaier cmaier requested a review from Fabtron December 7, 2023 12:35
@cmaier cmaier self-assigned this Dec 7, 2023
@cmaier cmaier merged commit d6ba63d into main Dec 7, 2023
@cmaier cmaier deleted the apps-1252-credit-card-validation branch December 7, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants