Add support for custom properties (e.g. external billing, subject length) #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabtron
reviewed
Mar 28, 2024
ui/src/main/java/io/snabble/sdk/ui/payment/externalbilling/ui/widgets/SubjectAlertDialog.kt
Outdated
Show resolved
Hide resolved
Fabtron
requested changes
Mar 28, 2024
Collaborator
Fabtron
left a comment
Fabtron
left a comment
There was a problem hiding this comment.
Works good just some small change as suggestion
…-specific-property-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom properties can now be added and implemented easier. As an example the subject text edit for the external billing has been make configurable using a
CustomProperty.APPS-1491 (APPS-1497)
How to test?
Definition of Done
App Tests
Minified getestet? (aka. Release Build)Environements beachtet (Production/Staging)Unterstützte Sprachen sind getestetLight-/Dark-Mode getestetTesting
Tests geschrieben (aka Unit-Tests, Integration-Tests)