Skip to content

Conversation

@ajungg
Copy link
Member

@ajungg ajungg commented Feb 21, 2022

No description provided.

@ajungg ajungg requested a review from rekire February 21, 2022 14:22
Copy link
Contributor

@rekire rekire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes are fine. However there are still some usages of "sp", here are some samples:
java-sample/src/main/res/layout/item_dropdown.xml
kotlin-sample/src/main/res/layout/fragment_home.xml
java-sample/src/main/res/layout/item_dropdown.xml
ui/src/main/res/layout/snabble_buy_with_googlepay_button.xml
ui/src/main/res/layout/snabble_buy_with_googlepay_button_no_shadow.xml
ui/src/main/res/layout/snabble_googlepay_button.xml
ui/src/main/res/layout/snabble_googlepay_button_no_shadow.xml
ui/src/main/res/layout/snabble_item_shoppingcart_product.xml
ui/src/main/res/layout/snabble_view_cardinput_sepa.xml

Please verify yourself if those are fine.

There are some TextViews without a textAppearance attribute. you can search them with this handy regex: <TextView((?!textAppearance)[^>])*> (limit it to *.xml files)
This results for me this list to verify:
java-sample/src/main/res/layout/activity_main.xml
java-sample/src/main/res/layout/item_dropdown.xml
kotlin-sample/src/main/res/layout/activity_loading.xml
kotlin-sample/src/main/res/layout/activity_home.xml
kotlin-sample/src/main/res/layout/activity_success.xml

All sample code yes, but why not applying best practices there too?

@ajungg ajungg merged commit 6cf8678 into master Feb 23, 2022
@rekire rekire deleted the accessibility_improvements branch March 3, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants