Skip to content

Integrate remote theming (Apps-1773) #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fabtron merged 47 commits into from
Sep 10, 2024
Merged

Integrate remote theming (Apps-1773) #208

Fabtron merged 47 commits into from
Sep 10, 2024

Conversation

@Fabtron
Copy link
Collaborator

@Fabtron Fabtron commented Sep 4, 2024 •
edited
Loading

To provide the option to customize some parts of the ui, a remote theme has been added in the metadata. To apply this theme automatically in the existing ui some part have been replaced with new custom components, wich sets the remote theme if it is provided.

APPS-1773

How to test?

Definition of Done

  • Issue is linked
  • All requirements of the issue are fulfilled
  • Changelog is updated
  • Documentation is updated
  • Self-Review
  • Review with the Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified build has been tested (aka. Release Build)
  • Environments have been taken care of (Production/Staging)
  • Supported languages have been tested
  • Light-/Dark-Mode has been tested
  • Edge-Cases have been tested
  • Android API Levels have been taken care of (minSdk?)

Testing

  • Tests have been written (aka Unit-Tests, Integration-Tests, ...)

Fabtron added 30 commits August 27, 2024 09:38
@Fabtron
add new property to the project containing the app theme
a677fb9
@Fabtron
WIP: Replace MaterialButton with CustomView e.g. SnabblePrimaryButton
e2ea58e
@Fabtron
WIP: make compose fun public
8bd358b
@Fabtron
WIP: only set background color
7c2097c
@Fabtron
WIP: fix typo
a0a528a
@Fabtron
WIP: add dependency for live data as flow extension
895c774
@Fabtron
WIP: remove observe forever and create extension functions for theming
448c011
@Fabtron
WIP: adjust primary button default style and add second impl for seco…
61aed6d 
…ndary buttons
@Fabtron
add TextView with default primary color
d9f48b0
@Fabtron
remove obsolete loading of the theme and change parsing to get direct…
d26964d 
…ly through the metadata
@Fabtron
use json element instead of the object
c703a6f
@Fabtron
switch to secondary button
d0fb844
@Fabtron
split up theme into light and dark mode colors
2ea2069
@Fabtron
rename
a8d0d95
@Fabtron
rewrite extension functions to provide the color depending on the ui …
73f940e 
…mode
@Fabtron
WIP: set text colors according to the remote theme
3aa6b72
@Fabtron
refactor to make it more readable and renaming
1a27cc1
@Fabtron
set button color for alert dialog
5ce21ae
@Fabtron
add option to show keyboard via the TextFieldManager
767bef7
@Fabtron
apply remote theme to compose theme
9b25725
@Fabtron
migrate searchbar to compose to apply remote theme
e803ee7
@Fabtron
roll back to use material button
c5e5fd8
@Fabtron
adjust alert dialog color
3015d35
@Fabtron
move theme into own package and revert some formatting's
26c4ca3
@Fabtron
revert obsolete changes
928c124
@Fabtron
revert some formatting's
f767f57
@Fabtron
remove obsolete blank line
8fbc082
@Fabtron
rename function to match it's usage
48e00e3
@Fabtron
formatting and change import
9b85318
@Fabtron
revert changes
c6e8a9f
@Fabtron Fabtron merged commit 8866295 into main Sep 10, 2024
@Fabtron Fabtron deleted the apps-1773-remote-theming branch September 10, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Fabtron