Skip to content

Add customization config to project to load remote assets (Apps-1771) #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fabtron merged 32 commits into from
Sep 13, 2024
Merged

Add customization config to project to load remote assets (Apps-1771) #211

Fabtron merged 32 commits into from
Sep 13, 2024

Conversation

@Fabtron
Copy link
Collaborator

@Fabtron Fabtron commented Sep 13, 2024 •
edited
Loading

To provide remote assets the customization config has been added.

APPS-1771

How to test?

Definition of Done

  • Issue is linked
  • All requirements of the issue are fulfilled
  • Changelog is updated
  • Documentation is updated
  • Self-Review
  • Review with the Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified build has been tested (aka. Release Build)
  • Environments have been taken care of (Production/Staging)
  • Supported languages have been tested
  • Light-/Dark-Mode has been tested
  • Edge-Cases have been tested
  • Android API Levels have been taken care of (minSdk?)

Testing

  • Tests have been written (aka Unit-Tests, Integration-Tests, ...)

@Fabtron
fix bug in PurchasesRepository
21d1297
@Fabtron
replace old primary button with new on to keep colors for states like…
e0588c3 
… disables, hovered, etc.
@Fabtron
remove logs
8ace083
@Fabtron
remove obsolete styles
5452798
@Fabtron
change to cast to primary button
773a2aa
@Fabtron
change to cast to primary button
491fa07
@Fabtron
adjust floating action buttons and deletion dialog
d2a73eb
@Fabtron
change to cast to primary button
bd76f9b
@Fabtron
revert external billing subject dialog changes since it is not needed
c45e879
@Fabtron
change to cast to primary button
5684ab1
@Fabtron
change to cast to primary button
27eb064
@Fabtron
roll back to use default button
8afad11
@Fabtron
change to cast to snabble primary button
1b0a8fc
@Fabtron
change to cast to snabble primary button
3b99acd
@Fabtron
set dispose strategy
241ec1f
@Fabtron
switch to use primary color
6201731
@Fabtron
rename
da16595
@Fabtron
remove obsolete declaration
3609ff0
@Fabtron
override onclickListener to ensure that it is actually called
65e0d1d
@Fabtron
adjust button to use layout height and fontsize set via xml
3861398
@Fabtron
convert to lambda ref
b1fe2ba
@Fabtron
change button style
e902114
@Fabtron
WIP: Add style to customize the snabble primary button
41726fa
@Fabtron
WIP: add snabble primary button style
23136a2
@Fabtron
WIP: add snabble primary button style if needed
ed03e81
@Fabtron
WIP: add method to apply project theme
9ed2a93
@Fabtron
provide customization config
4aea64d
@Fabtron
Merge branch 'refs/heads/main' into apps-1771-remote-assets
b8a7096 
# Conflicts:
#	ui-toolkit/src/main/kotlin/io/snabble/sdk/widgets/snabble/purchase/repository/PurchasesRepository.kt
#	ui/src/main/java/io/snabble/sdk/ui/payment/PaymentCredentialsListView.java
#	ui/src/main/java/io/snabble/sdk/ui/remotetheme/SnabblePrimaryButton.kt
@Fabtron
make setter private
7881fa8
@Fabtron
revert obsolete changes
536c7f9
@Fabtron Fabtron merged commit 88f2c9d into main Sep 13, 2024
@Fabtron Fabtron deleted the apps-1771-remote-assets branch September 13, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fabtron