Skip to content

Conversation

@cmaier
Copy link
Contributor

@cmaier cmaier commented Dec 4, 2024

We don't do SSL Pinning anymore. Anywhere.
Due to this, the SSL Pinning has been removed and SSL Pinning for the payment provider Datatrans has been deactivated.

APPS-1821

How to test?

  • Integrate this branch in any of our projects and see if requests still work.
  • Check in a project w/ Datatrans as payment provider if checkouts are proceeded as usual.

Definition of Done

  • Issue is linked
  • All requirements of the issue are fulfilled
  • Changelog is updated
  • Documentation is updated
  • Self-Review
  • Review with the Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified build has been tested (aka. Release Build)
  • Environments have been taken care of (Production/Staging)
  • Supported languages have been tested
  • Light-/Dark-Mode has been tested
  • Edge-Cases have been tested
  • Android API Levels have been taken care of (minSdk?)

Testing

  • Tests have been written (aka Unit-Tests, Integration-Tests, ...)

@cmaier cmaier self-assigned this Dec 4, 2024
@cmaier cmaier marked this pull request as ready for review December 4, 2024 07:45
@cmaier cmaier requested a review from Fabtron December 4, 2024 07:45
@cmaier cmaier merged commit 955dcc9 into main Dec 5, 2024
1 check passed
@cmaier cmaier deleted the apps-1821-remove-certificate-pinning branch December 5, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants