Skip to content

Conversation

@Fabtron
Copy link
Collaborator

@Fabtron Fabtron commented Dec 11, 2024

The following changes haven been applied:

  • adjust brightness if the exit code is shown
  • make the exit code bigger and add a background for better scanning experience (add safezone for scanning)
  • move the hint to be the sub title of the section

APPS-1795

How to test?

Integrate this branch into an app where the exit code is shown on a checkout and and do a checkout.

Definition of Done

  • Issue is linked
  • All requirements of the issue are fulfilled
  • Changelog is updated
  • Documentation is updated
  • Self-Review
  • Review with the Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified build has been tested (aka. Release Build)
  • Environments have been taken care of (Production/Staging)
  • Supported languages have been tested
  • Light-/Dark-Mode has been tested
  • Edge-Cases have been tested
  • Android API Levels have been taken care of (minSdk?)

Testing

  • Tests have been written (aka Unit-Tests, Integration-Tests, ...)

* adjust brightness if the exit code is shown
* make the exit code bigger and add a background for better scanning experience
* move the hint to be the sub title
@Fabtron Fabtron marked this pull request as ready for review December 11, 2024 21:02
@Fabtron Fabtron requested a review from cmaier December 11, 2024 21:02
Copy link
Contributor

@cmaier cmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

The same behavior should be added so show-again feature:

1 2
Pixel_7-1733982071 Pixel_7-1733982076

@Fabtron
Copy link
Collaborator Author

Fabtron commented Dec 12, 2024

Nice :)

The same behavior should be added so show-again feature:
1 2
Pixel_7-1733982071 Pixel_7-1733982076

We have no issues there. The changes came from Support requests and only relates to the exit code in the success screen. So there will be (at this point no) no changes for this screen, since we could change it on every place where we generate a qr code via the barcode view.

@Fabtron Fabtron merged commit a6a0a2d into main Dec 12, 2024
1 check passed
@Fabtron Fabtron deleted the apps-1795-adjust-exit-qr-code branch December 12, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants