Skip to content

Fix missing focus on the product search field (Apps-1995) #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fabtron merged 4 commits into from
Dec 12, 2024
Merged

Fix missing focus on the product search field (Apps-1995) #229

Fabtron merged 4 commits into from
Dec 12, 2024

Conversation

@Fabtron
Copy link
Collaborator

@Fabtron Fabtron commented Dec 12, 2024 •
edited
Loading

Changed it to request the focus after the widget is positioned to ensure that the focus requester is initialized.

APPS-1995

How to test?

Launch the app and chechout if the focus works again when searching a product manually.

Definition of Done

  • Issue is linked
  • All requirements of the issue are fulfilled
  • Changelog is updated
  • Documentation is updated
  • Self-Review
  • Review with the Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified build has been tested (aka. Release Build)
  • Environments have been taken care of (Production/Staging)
  • Supported languages have been tested
  • Light-/Dark-Mode has been tested
  • Edge-Cases have been tested
  • Android API Levels have been taken care of (minSdk?)

Testing

  • Tests have been written (aka Unit-Tests, Integration-Tests, ...)

@Fabtron Fabtron marked this pull request as ready for review December 12, 2024 06:33
@Fabtron Fabtron requested a review from cmaier December 12, 2024 06:33
cmaier
cmaier approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@cmaier cmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the bug 👍

@Fabtron Fabtron merged commit 6a7867f into main Dec 12, 2024
1 check passed
@Fabtron Fabtron deleted the apps-1995-fix-missing-barcode-search-input-focus branch December 12, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cmaier cmaier cmaier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fabtron @cmaier