Handle invalid drv and other items (Apps-2039) #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner-support-for-deposit-voucher
…ve for to return the id's of the invalid items to resolve cart items that are not part of products
…into apps-1642-add-scanner-support-for-invalid-drv-and-other-items # Conflicts: # core/src/main/java/io/snabble/sdk/checkout/CheckoutApi.kt # core/src/main/java/io/snabble/sdk/checkout/DefaultCheckoutApi.kt # core/src/main/java/io/snabble/sdk/codes/ScannedCode.kt # core/src/main/java/io/snabble/sdk/codes/templates/depositReturnVoucher/DepositReturnVoucherProvider.kt # core/src/main/java/io/snabble/sdk/shoppingcart/ShoppingCart.kt # core/src/main/java/io/snabble/sdk/shoppingcart/ShoppingCartUpdater.kt # ui/src/main/java/io/snabble/sdk/ui/scanner/SelfScanningExtensions.kt # ui/src/main/java/io/snabble/sdk/ui/scanner/SelfScanningView.java
Fabtron
changed the title
…into apps-1642-add-scanner-support-for-invalid-drv-and-other-items # Conflicts: # CHANGELOG.md # ui/src/main/res/values-de/strings.xml # ui/src/main/res/values/strings.xml
cmaier
suggested changes
Jan 6, 2025
core/src/main/java/io/snabble/sdk/shoppingcart/ShoppingCartUpdater.kt
Outdated
Show resolved
Hide resolved
…r-invalid-drv-and-other-items' into apps-1642-add-scanner-support-for-invalid-drv-and-other-items
cmaier
approved these changes
Jan 7, 2025
Fabtron
deleted the
apps-1642-add-scanner-support-for-invalid-drv-and-other-items
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
If a deposit return voucher is invalid we need to handle it. Since we can't define that we received an invalid drv and only do a match up via the id from the error the message is adjusted to match that of a product.
We dialog is integrated in several places. E.g. in the selfscanning view to ensure that it will be removed directly by the user after it was added and in the checkoutbar to ensure that a checkout can't be started if a invalid product is part of the cart (this was the previous way).
APPS-2039
How to test?
Integrate this branch into an application and scan the barcode mentioned in the ticket.
Definition of Done
App Tests
Testing