Skip to content

Conversation

@Fabtron
Copy link
Collaborator

@Fabtron Fabtron commented Jan 3, 2025

In case that there is no default (hardcoded) origintype set in the payment method type, we now try to add it from the matching payment method descriptor.

APPS-888

How to test?

Add logging in the newly added part and try it out in different project with different origintype set for the payment methods (e.g. add this method and do a checkout)

Definition of Done

  • Issue is linked
  • All requirements of the issue are fulfilled
  • Changelog is updated
  • Documentation is updated
  • Self-Review
  • Review with the Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified build has been tested (aka. Release Build)
  • Environments have been taken care of (Production/Staging)
  • Supported languages have been tested
  • Light-/Dark-Mode has been tested
  • Edge-Cases have been tested
  • Android API Levels have been taken care of (minSdk?)

Testing

  • Tests have been written (aka Unit-Tests, Integration-Tests, ...)

@Fabtron Fabtron marked this pull request as ready for review January 3, 2025 10:09
@Fabtron Fabtron requested a review from cmaier January 3, 2025 10:09
@Fabtron Fabtron merged commit 2631724 into main Jan 7, 2025
1 check passed
@Fabtron Fabtron deleted the apps-888-add-origin-type-to-checkout-process branch January 7, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants