Skip to content

Conversation

@Fabtron
Copy link
Collaborator

@Fabtron Fabtron commented Jan 7, 2025

APPS-1939

The color ist adjusted if we have a negative amount for the totals price. Also the label for the button changes if the amount of the total price equals zero.

APPS-2049

Every signedCheckoutInfo is now handled as a success and only valid violations are supported.

How to test?

APPS-1939 -> Follow the instructions mentioned in the ticket
APPS-2049 -> Follow the instructions mentioned in the ticket

Definition of Done

  • Issue is linked
  • All requirements of the issue are fulfilled
  • Changelog is updated
  • Documentation is updated
  • Self-Review
  • Review with the Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified build has been tested (aka. Release Build)
  • Environments have been taken care of (Production/Staging)
  • Supported languages have been tested
  • Light-/Dark-Mode has been tested
  • Edge-Cases have been tested
  • Android API Levels have been taken care of (minSdk?)

Testing

  • Tests have been written (aka Unit-Tests, Integration-Tests, ...)

@Fabtron Fabtron changed the title Add changes for zero amount checkout (Apps-1939) Add changes for zero amount checkout and drv first support (Apps-1939/ 2049) Jan 10, 2025
@Fabtron Fabtron requested a review from cmaier January 10, 2025 08:03
@Fabtron Fabtron marked this pull request as ready for review January 10, 2025 08:03
@Fabtron Fabtron merged commit 9bf10bf into feature-deposit-return-voucher Jan 10, 2025
1 check passed
@Fabtron Fabtron deleted the apps-1939-zero-amount-checkout branch January 10, 2025 12:12
@Fabtron Fabtron mentioned this pull request Jan 15, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants