Skip to content

Last minor fixes (APPS-2054) #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fabtron merged 8 commits into from
Jan 15, 2025
Merged

Last minor fixes (APPS-2054) #237

Fabtron merged 8 commits into from
Jan 15, 2025

Conversation

@Fabtron
Copy link
Collaborator

@Fabtron Fabtron commented Jan 13, 2025 •
edited
Loading

  • The local price has been updated to include a local price for deposit return voucher so that the total price is always up to date.
  • The displayname for the deposit return voucher has been changed to return the total price instead of the scanned code.
  • Also so some minor changes that are required.

APPS-2054

How to test?

Definition of Done

  • Issue is linked
  • All requirements of the issue are fulfilled
  • Changelog is updated
  • Documentation is updated
  • Self-Review
  • Review with the Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified build has been tested (aka. Release Build)
  • Environments have been taken care of (Production/Staging)
  • Supported languages have been tested
  • Light-/Dark-Mode has been tested
  • Edge-Cases have been tested
  • Android API Levels have been taken care of (minSdk?)

Testing

  • Tests have been written (aka Unit-Tests, Integration-Tests, ...)

@Fabtron Fabtron changed the base branch from main to feature-deposit-return-voucher January 13, 2025 16:58
@Fabtron Fabtron marked this pull request as ready for review January 13, 2025 17:03
@Fabtron Fabtron requested a review from cmaier January 13, 2025 17:03
cmaier
cmaier suggested changes Jan 14, 2025
View reviewed changes
@Fabtron Fabtron requested a review from cmaier January 14, 2025 15:00
@Fabtron Fabtron merged commit 0eeea07 into feature-deposit-return-voucher Jan 15, 2025
1 check passed
@Fabtron Fabtron deleted the minor-drv-fixes branch January 15, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaier cmaier Awaiting requested review from cmaier

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fabtron @cmaier