Skip to content

Fix crash on empty project list in :ui-toolkit:CustomerCard #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmaier merged 3 commits into from
Nov 8, 2022
Merged

Fix crash on empty project list in :ui-toolkit:CustomerCard #77

cmaier merged 3 commits into from
Nov 8, 2022

Conversation

@cmaier
Copy link
Contributor

@cmaier cmaier commented Nov 8, 2022 •
edited
Loading

:ui-toolkit

Snabble.projects might be empty so a List.first() call will crash. To prevent that the HasCustomerCardUseCaseImpl will now use List.firstOrNull().

Additionally:

  • the constructor parameter val Snabble: Snabble now start with a lower case s.
  • The PurchaseViewModel makes now use of a new GetPurchasesUseCase instead of using the repo directly.

@cmaier cmaier requested a review from Fabtron November 8, 2022 07:41
@cmaier cmaier changed the title Fix crash on empty project list in CustomerCard Fix crash on empty project list in :ui-toolkit:CustomerCard Nov 8, 2022
@cmaier cmaier merged commit 10078fc into main Nov 8, 2022
@cmaier cmaier deleted the fix-crash-on-empty-project-list branch November 8, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fabtron Fabtron Fabtron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmaier @Fabtron