tests: port xdg-settings test to tests.session#8804
Merged
Conversation
This is the last of the big set of tests that spawn dbus-daemon via dbus-launch, leaking it for the reminder of the test suite. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
mvo5
reviewed
Jun 4, 2020
| # a user session environment there | ||
| systems: [-ubuntu-core-*] | ||
| systems: | ||
| - -amazon-linux-2-* |
Contributor
There was a problem hiding this comment.
Maybe a comment here why all these systems are now excluded?
Contributor
Author
There was a problem hiding this comment.
Would you mind if I do a pass over all the tests that share this characteristic and unify the comments? We kind of have a patchwork of comments that try to say the same thing in different ways now.
Contributor
There was a problem hiding this comment.
Either way is fine, I was mostly commenting because the old test just disabled ubuntu-core and the updated test disables a bunch more.
While working on another related test it struck me that the DISPLAY environment variable set in the test is entirely irrelevant, because tests.session exec gives the process a pristine environment. Quick local confirmation shows that it is indeed not doing anything and can be removed. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last of the big set of tests that spawn dbus-daemon via
dbus-launch, leaking it for the reminder of the test suite.
Signed-off-by: Zygmunt Krynicki me@zygoon.pl