tests: port snap-handle-link test to tests.session#8815
Merged
Conversation
This test used DBus activation and leaves another dbus-daemon around. It was picked up by the invariant detector. This test is interesting because it makes it obvious why we set DISPLAY to a fake value. I may circle back to earlier tests that have a similar property and handle that better there. In addition, xdg-open on the host can now correctly handle desktop files on 16.04 so I made the test not skip that part. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
bboozzoo
reviewed
Jun 5, 2020
Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
bboozzoo
approved these changes
Jun 5, 2020
|
|
||
| # Make sure there is a default handler to open a snap package | ||
| tests.session -u test exec mkdir -p /home/test/.config | ||
| tests.session -u test exec mv /home/test/.config /home/test/.config.bak |
Contributor
There was a problem hiding this comment.
Could be a copy, but mv is ok too.
bboozzoo
reviewed
Jun 5, 2020
| # Make sure there is a default handler to open a snap package | ||
| tests.session -u test exec mkdir -p /home/test/.config | ||
| tests.session -u test exec mv /home/test/.config /home/test/.config.bak | ||
| tests.session -u test exec mkdir -p /home/test/.config |
Contributor
There was a problem hiding this comment.
This line is not needed anymore.
Contributor
Author
There was a problem hiding this comment.
Just making sure there's a .config directory in case something here needs it.
Contributor
There was a problem hiding this comment.
Exactly the same thing is done in line 14.
Edit: heh, misread it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test used DBus activation and leaves another dbus-daemon around. It
was picked up by the invariant detector.
This test is interesting because it makes it obvious why we set DISPLAY
to a fake value. I may circle back to earlier tests that have a similar
property and handle that better there.
In addition, xdg-open on the host can now correctly handle desktop files
on 16.04 so I made the test not skip that part.
Signed-off-by: Zygmunt Krynicki me@zygoon.pl