Skip to content

Bump deps: criterion, base, text, unix-compat, vector#150

Merged
cydparser merged 3 commits intosnapframework:masterfrom
ysangkok:janus/bump-deps
Nov 9, 2022
Merged

Bump deps: criterion, base, text, unix-compat, vector#150
cydparser merged 3 commits intosnapframework:masterfrom
ysangkok:janus/bump-deps

Conversation

@ysangkok
Copy link
Copy Markdown
Contributor

@ysangkok ysangkok commented Aug 14, 2022

Includes #149.

This enables building on GHC 9.4 and 9.2, which can be tested using e.g.:

cabal test -w ghc-9.4.1 --constraint='text>=2.0' --constraint='unix-compat>=0.6' --constraint='criterion>=1.6'

I haven't set the constraint for vector yet, as it depends on snap-core bumping its bound. But it can be tested with --allow-newer='snap-core:vector' --constraint='vector>=0.13'

This was referenced Aug 15, 2022
@andreasabel
Copy link
Copy Markdown

@mightybyte : Could you please push the button to run CI?

@ysangkok ysangkok changed the title Bump deps: criterion, transformers, base, text, unix, unix-compat, vector Bump deps: criterion, base, text, unix, unix-compat, vector Aug 17, 2022
@ysangkok
Copy link
Copy Markdown
Contributor Author

ysangkok commented Aug 17, 2022

I realized that I had forgotten to add 9.2 to CI. It is now done. The results can be seen here: https://github.com/ysangkok/snap-server/runs/7885561429?check_suite_focus=true

Also, I removed the bump of transformers since I'd prefer bumping when mtl is also bumped, in a separate PR.

@andreasabel
Copy link
Copy Markdown

I realized that I had forgotten to add 9.2 to CI

Would be great if 9.4 also was covered by CI. Is there an obstacle?

@ysangkok
Copy link
Copy Markdown
Contributor Author

ysangkok commented Aug 18, 2022

@andreasabel Indeed it would be nice to run CI for 9.4, but it is blocked on basvandijk/threads#17. I was optimistically thinking that if we could get threads updated, there would be no need to work on excluding 9.4 on CI from running the testsuite here in snap-server, which would be necessary in case threads never updates. But even though the threads library is very old, it looks like @basvandijk is still active, so I'd thinking we'd just wait a couple of weeks. By then, if there is no reply, I can take over the package, it doesn't look like it needs a lot of maintenance. At that point, I would add another commit to this PR, adding CI for GHC 9.4.

Does it sound like a sensible plan?

EDIT: Released threads-0.5.1.7 and added CI for 9.4 to this PR

Comment thread snap-server.cabal Outdated
cpp-options: -DPORTABLE
else
build-depends: unix < 2.8
build-depends: unix < 2.9
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is unix-2.8 picked up yet? (Check output of cabal-plan.) It is so that process so far limits unix < 2.8.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't picked up, and as you mention, it doesn't build with unix-2.8. So I removed that change from this PR.

@andreasabel
Copy link
Copy Markdown

@mightybyte : Would you please trigger the CI run?

@ysangkok ysangkok changed the title Bump deps: criterion, base, text, unix, unix-compat, vector Bump deps: criterion, base, text, unix-compat, vector Aug 23, 2022
@peterbecich
Copy link
Copy Markdown
Contributor

@imalsogreg would you approve this workflow? Thx

@cydparser
Copy link
Copy Markdown
Contributor

Thanks!

@cydparser cydparser merged commit 342822c into snapframework:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants