Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
bmr-cymru
force-pushed
the
bmr-lvm-json-std
branch
4 times, most recently
from
d1697bb to
d722e3f
Compare
bmr-cymru
changed the title
bmr-cymru
force-pushed
the
bmr-lvm-json-std
branch
2 times, most recently
from
dbc33df to
c69ddfc
Compare
Accept either JSON output format for the mock versions of the LVM reporting commands. The fields parsed by the lvm2 plugins are not affected by the JSON format version so the mock output is unchanged.
Since lvm2 on Ubuntu-24.04 does not support the --reportformat json_std argument refactor the lvm2 plugin helper functions that call out to lvm2 reporting commands to be methods of the Lvm2 plugin class. This allows the plugin to detect the lvm2 version when it is initialised and set a private property, _json_fmt to the required --reportformat string. Subsequent calls to the helpers can then use this value to issue the appropriate command line arguments for the running lvm2 version. Amend test cases for the corresponding functions to use the appropriate object type for helper unit tests. Related: #110
Check whether the installed version of lvm2 supports the 'json_std' --reportformat argument and switch back to 'json' for old versions. Resolves: #110
Unless explicitly set on the command line the report format used by the lvm2 tools may be influenced by settings in the environment or configuration files. For example, setting LVM_COMMAND_PROFILE selects an alternate configuration file from /etc/lvm/profiles, which may override the report/output_format option. Prevent this by always setting the --reportformat explicitly on the lvm2 command line as is already done in other plugin helpers. Resolves: #109
Make the vg_lv_from_device_path() helper a method of the Lvm2 plugins: this facilitates applying environment variable sanitisation to the lvm calls in a subsequent commit. Related: #112
There are numerous LVM2 environment variables (see lvm(8)) that can influence the behaviour of the commands that snapm relies on in the lvm2 plugins. Filter the environment when initialising the plugin to discard any unwanted variables: the LVM_SYSTEM_DIR environment variable is explicitly excluded since it is used in the test suite and can be used legitimately to direct snapm to an alternate LVM configuration. Resolves: #112
bmr-cymru
force-pushed
the
bmr-lvm-json-std
branch
from
c69ddfc to
36e7b71
Compare
The Stratis project released 3.8.0 today and the 3.7.0 package is no longer available on pip: switch to installing from git and pin to the old release for now. Related: #113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #109, #110, #112.