Fix lvm2 environment variable filtering#294
Merged
Conversation
Having to pass env=self._env to every run() call is repetitive and fragile: introduce a thin wrapper around subprocess.run() that sets env= to the sanitized environment stored in self._env. Callers can override the sanitized environment where needed by calling `self._run()` with the env keyword argument: in this case the two dictionaries are merged before calling run(). Environment variables in the value passed in by the caller take precedence over the defaults. Resolves: #291
Make _get_lvm_version() a method of the abstract _Lvm2 class, allowing enforcement of the lvm environment sanitization. Related: #292
Make is_lvm_device() a method of the abstract _Lvm2 class, allowing enforcement of the lvm environment sanitization. Related: #292
Make _activate() a method of the abstract _Lvm2 class, allowing enforcement of the lvm environment sanitization. Resolves: #292
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
1 similar comment
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #290
Resolves: #291
Resolves: #292
Resolves: #293