Warn user to reboot when reverting a snapset with in-use origin devices#39
Merged
Warn user to reboot when reverting a snapset with in-use origin devices#39
Conversation
Avoids confusion with the Manager.revert_snapshot_sets() interface.
This will be used to detect whether a snapshot set's origin is in use when initiating a revert action.
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
bmr-cymru
force-pushed
the
bmr-check-mounted-revert
branch
from
276d228 to
28676c2
Compare
Revert operations require a reboot to take effect when the origin volumes are in use. Detect this in Manager.revert_snapshot_sets() and warn the user.
bmr-cymru
force-pushed
the
bmr-check-mounted-revert
branch
from
28676c2 to
d5320fd
Compare
Allow reverting a single snapshot set by name or uuid. Multiple snapshot sets can be reverted in a single operation as before by calling Manager.revert_snapset() with a Selection argument.
bmr-cymru
force-pushed
the
bmr-check-mounted-revert
branch
from
ce3f90e to
08df509
Compare
bmr-cymru
force-pushed
the
bmr-check-mounted-revert
branch
from
c284bf5 to
9dd980c
Compare
bmr-cymru
force-pushed
the
bmr-check-mounted-revert
branch
from
dc7af38 to
88d778b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert operations require a reboot to take effect when the origin volumes are in use. Detect this in Manager.revert_snapshot_sets() and warn the user.