Skip to content

snapm: minor typos and typing fixes#576

Merged
bmr-cymru merged 4 commits intomainfrom
bmr-minor-fixes
Oct 28, 2025
Merged

snapm: minor typos and typing fixes#576
bmr-cymru merged 4 commits intomainfrom
bmr-minor-fixes

Conversation

@bmr-cymru
Copy link
Copy Markdown
Contributor

@bmr-cymru bmr-cymru commented Oct 28, 2025

Resolves: #572
Resolves: #573
Resolves: #574
Resolves: #575

Summary by CodeRabbit

  • Documentation

    • Corrected typographical errors in command documentation and parameter descriptions.
    • Clarified command handler descriptions for improved consistency and accuracy.
  • Chores

    • Added an internal type clarification for machine identifier handling; no change to user-visible behaviour.

Resolves: #572

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Resolves: #573

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Resolves: #574

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
@bmr-cymru bmr-cymru self-assigned this Oct 28, 2025
@bmr-cymru bmr-cymru added the Bug Something isn't working label Oct 28, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 28, 2025

Walkthrough

These changes fix documentation and type annotation issues: correcting three typos in docstrings within snapm/command.py (autoinxed → autoindex, comma-separateed → comma-separated, and Delete → Revert) and adding an Optional[str] return type annotation to _get_machine_id() in snapm/manager/_boot.py with corresponding docstring updates.

Changes

Cohort / File(s) Summary
Documentation typos in command module
snapm/command.py
Fixed three documentation typos: parameter name "autoinxed" → "autoindex" in create_schedule docstring; "comma-separateed" → "comma-separated" in print_schedules docstring; command description "Delete" → "Revert" in _revert_cmd docstring.
Type annotation and documentation in boot module
snapm/manager/_boot.py
Added Optional[str] return type annotation to _get_machine_id() and updated its docstring to indicate the function may return None.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Small set of documentation fixes and a single, non-behavioural type annotation change.
  • Pay attention to the _get_machine_id() signature change and docstring wording consistency.

Suggested labels

documentation, Cleanup

Poem

🐰 Typos hopped away with grace,
Docstrings neat in every place.
"autoinxed" tuned to "autoindex" bright,
Machine IDs now typed just right.
A tiny hop — the docs delight ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "snapm: minor typos and typing fixes" accurately describes the scope of changes in the changeset. The PR addresses two categories of modifications: typo corrections in snapm/command.py (fixing "autoinxed", "comma-separateed", and "Delete" to "Revert") and a typing fix in snapm/manager/_boot.py (adding Optional type annotation). The title is concise, clear, and specific enough to convey the primary intent to someone reviewing the commit history.
Linked Issues Check ✅ Passed All four linked issues have been addressed by the code changes. Issue #572 requires fixing the _revert_cmd docstring from "Delete" to "Revert", which is confirmed in the raw summary. Issue #573 requires fixing the "autoinxed" typo to "autoindex" in the create_schedule parameter documentation, which is present. Issue #574 requires fixing "comma-separateed" to "comma-separated" in print_schedules documentation, which is confirmed. Issue #575 requires adding an Optional type annotation to _get_machine_id and updating its docstring, which the raw summary confirms has been implemented.
Out of Scope Changes Check ✅ Passed All changes in the pull request are directly aligned with the objectives specified in the linked issues. The modifications target only two files—snapm/command.py and snapm/manager/_boot.py—with all changes relating to the four specific issues (#572, #573, #574, #575). The raw summary notes that only documentation text updates and a type annotation addition are present, with no extraneous modifications detected.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bmr-minor-fixes

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7483c2c and f5248d6.

📒 Files selected for processing (1)
  • snapm/manager/_boot.py (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • snapm/manager/_boot.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (45)
  • GitHub Check: rpm-build:epel-9-x86_64
  • GitHub Check: rpm-build:fedora-43-x86_64
  • GitHub Check: rpm-build:fedora-41-x86_64
  • GitHub Check: rpm-build:fedora-rawhide-x86_64
  • GitHub Check: rpm-build:centos-stream-9-x86_64
  • GitHub Check: rpm-build:centos-stream-10-x86_64
  • GitHub Check: rpm-build:fedora-42-x86_64
  • GitHub Check: rpm-build:fedora-42-x86_64
  • GitHub Check: rpm-build:centos-stream-9-x86_64
  • GitHub Check: rpm-build:epel-9-x86_64
  • GitHub Check: rpm-build:fedora-rawhide-x86_64
  • GitHub Check: rpm-build:fedora-41-x86_64
  • GitHub Check: rpm-build:centos-stream-10-x86_64
  • GitHub Check: rpm-build:fedora-43-x86_64
  • GitHub Check: rpm-build:fedora-42-x86_64
  • GitHub Check: rpm-build:centos-stream-9-x86_64
  • GitHub Check: rpm-build:epel-9-x86_64
  • GitHub Check: rpm-build:fedora-rawhide-x86_64
  • GitHub Check: rpm-build:fedora-41-x86_64
  • GitHub Check: rpm-build:centos-stream-10-x86_64
  • GitHub Check: rpm-build:fedora-43-x86_64
  • GitHub Check: rpm-build:fedora-41-x86_64
  • GitHub Check: rpm-build:fedora-43-x86_64
  • GitHub Check: rpm-build:fedora-rawhide-x86_64
  • GitHub Check: rpm-build:centos-stream-10-x86_64
  • GitHub Check: rpm-build:fedora-42-x86_64
  • GitHub Check: rpm-build:centos-stream-9-x86_64
  • GitHub Check: rpm-build:epel-9-x86_64
  • GitHub Check: virt_tests (uefi, lvm, centos-stream9)
  • GitHub Check: virt_tests (uefi, lvm-thin, fedora41)
  • GitHub Check: virt_tests (uefi, lvm-thin, centos-stream9)
  • GitHub Check: virt_tests (uefi, lvm, fedora41)
  • GitHub Check: virt_tests (uefi, lvm, centos-stream10)
  • GitHub Check: virt_tests (uefi, lvm-thin, centos-stream10)
  • GitHub Check: virt_tests (bios, lvm-thin, centos-stream10)
  • GitHub Check: virt_tests (bios, lvm-thin, centos-stream9)
  • GitHub Check: virt_tests (bios, lvm, fedora42)
  • GitHub Check: virt_tests (uefi, lvm-thin, fedora42)
  • GitHub Check: virt_tests (bios, lvm, centos-stream10)
  • GitHub Check: virt_tests (uefi, lvm, fedora42)
  • GitHub Check: virt_tests (bios, lvm, fedora41)
  • GitHub Check: virt_tests (bios, lvm, centos-stream9)
  • GitHub Check: virt_tests (bios, lvm-thin, fedora42)
  • GitHub Check: virt_tests (bios, lvm-thin, fedora41)
  • GitHub Check: python-basic-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@packit-as-a-service
Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/snapshotmanager-snapm-576
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Resolves: #575

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
@bmr-cymru bmr-cymru merged commit f5248d6 into main Oct 28, 2025
30 of 31 checks passed
@bmr-cymru bmr-cymru deleted the bmr-minor-fixes branch November 10, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment