snapm: rename and schedule fixes for v0.5.1#601
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Resolves: #603 Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
The Timeline garbage collection policy has a critical bug where the first snapshot set created by a policy can be immediately deleted, even when the user has configured retention for weekly, daily, or hourly snapshots. This happens because the GcPolicyParamsTimeline class currently classifies snapshot sets by greedily assigning to categories "yearly", "quarterly", "monthly", "weekly", "daily", "hourly" - meaning that the first snapshot set is always classified as "yearly", and hence is subject to deletion if keep_yearly=0. Fix this by allowing snapshot sets to be assigned to multiple matching categories as appropriate (i.e. a snapshot set taken at Midnight, Mon 1 Jan 2024 is simultaneously "yearly", "weekly", "daily", and "hourly"), and only assigning a snapshot set for deletion if all category retention policies yield False. Resolves: #604 Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
2819e36 to
ea35493
Compare
Fixes for #590 and #592 backported to v0.5.1
Resolves: #603
Resolves: #604