Skip to content

snapm: rename and schedule fixes for v0.5.1#601

Merged
bmr-cymru merged 7 commits intosnapm-0.5-stablefrom
bmr-rename-and-schedule-fixes-v0.5.1
Nov 16, 2025
Merged

snapm: rename and schedule fixes for v0.5.1#601
bmr-cymru merged 7 commits intosnapm-0.5-stablefrom
bmr-rename-and-schedule-fixes-v0.5.1

Conversation

@bmr-cymru
Copy link
Copy Markdown
Contributor

@bmr-cymru bmr-cymru commented Nov 16, 2025

Fixes for #590 and #592 backported to v0.5.1

Resolves: #603
Resolves: #604

@bmr-cymru bmr-cymru self-assigned this Nov 16, 2025
@bmr-cymru bmr-cymru added Bug Something isn't working UI/UX User interface and experience Schedules Backport labels Nov 16, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 16, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bmr-rename-and-schedule-fixes-v0.5.1

Tip

📝 Customizable high-level summaries are now available!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide custom instructions to shape the summary (bullet lists, tables, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example:

"Create a concise high-level summary as a bullet-point list. Then include a Markdown table showing lines added and removed by each contributing author."


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@packit-as-a-service
Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/snapshotmanager-snapm-601
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Resolves: #603

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
The Timeline garbage collection policy has a critical bug where the
first snapshot set created by a policy can be immediately deleted, even
when the user has configured retention for weekly, daily, or hourly
snapshots.

This happens because the GcPolicyParamsTimeline class currently
classifies snapshot sets by greedily assigning to categories "yearly",
"quarterly", "monthly", "weekly", "daily", "hourly" - meaning that the
first snapshot set is always classified as "yearly", and hence is
subject to deletion if keep_yearly=0.

Fix this by allowing snapshot sets to be assigned to multiple matching
categories as appropriate (i.e. a snapshot set taken at Midnight, Mon 1
Jan 2024 is simultaneously "yearly", "weekly", "daily", and "hourly"),
and only assigning a snapshot set for deletion if all category retention
policies yield False.

Resolves: #604

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
@bmr-cymru bmr-cymru force-pushed the bmr-rename-and-schedule-fixes-v0.5.1 branch from 2819e36 to ea35493 Compare November 16, 2025 20:33
@bmr-cymru bmr-cymru merged commit ea35493 into snapm-0.5-stable Nov 16, 2025
2 of 9 checks passed
@bmr-cymru bmr-cymru deleted the bmr-rename-and-schedule-fixes-v0.5.1 branch December 21, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport Bug Something isn't working Schedules UI/UX User interface and experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant