Skip to content

Conversation

@bmr-cymru
Copy link
Contributor

@bmr-cymru bmr-cymru commented Jan 2, 2026

Bump everything up to 0.2.0 to reflect support for plugin priorities.

Resolved: #853

Summary by CodeRabbit

  • Chores

    • Updated plugin suite version to 0.2.0 across all components.
  • Documentation

    • Updated user guide to reflect version 0.2.0 in plugin examples and references.

✏️ Tip: You can customize this high-level summary in your review settings.

Bump everything up to 0.2.0 to reflect support for plugin priorities.

Resolved: #853

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 2, 2026

Walkthrough

A version bump across all plugins from 0.1.0 to 0.2.0, updating the base Plugin class, LVM2 Cow and Thin variants, Stratis plugin, documentation examples, and test expectations to reflect priority support enhancements.

Changes

Cohort / File(s) Summary
Plugin version definitions
snapm/manager/plugins/_plugin.py, snapm/manager/plugins/lvm2.py, snapm/manager/plugins/stratis.py
Version attribute bumped from 0.1.0 to 0.2.0 across base Plugin class and all concrete plugin implementations (Lvm2Cow, Lvm2Thin, Stratis)
Documentation and test updates
doc/user_guide.rst, tests/test_plugin.py
Documentation examples and test assertions updated to reflect new 0.2.0 version across plugin list and priority override examples

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

enhancement, LVM2

Poem

🐰 A hop, a skip, and versions rise,

From 0.1 to 0.2 in plugin guise,

Priority support now takes the stage,

Fresh numbers mark a new age! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarises the main change: bumping plugin versions from 0.1.0 to 0.2.0 across all affected plugins.
Linked Issues check ✅ Passed The pull request successfully implements the requirement from issue #853 to bump all plugin versions from 0.1.0 to 0.2.0 to reflect priority support additions.
Out of Scope Changes check ✅ Passed All changes are in scope and directly related to the version bumps requested in issue #853; no unrelated modifications or side changes are present.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 77ea002 and 374dd79.

📒 Files selected for processing (5)
  • doc/user_guide.rst
  • snapm/manager/plugins/_plugin.py
  • snapm/manager/plugins/lvm2.py
  • snapm/manager/plugins/stratis.py
  • tests/test_plugin.py
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: bmr-cymru
Repo: snapshotmanager/snapm PR: 357
File: snapm.spec:132-134
Timestamp: 2025-09-10T23:42:35.992Z
Learning: The snapm project maintainer bmr-cymru prefers scripted version bumping as part of the snapm-x.y.z-release-prep workflow rather than automated regex-based parsing for version synchronization across files.
Learnt from: bmr-cymru
Repo: snapshotmanager/snapm PR: 541
File: snapm/manager/_mounts.py:174-197
Timestamp: 2025-10-22T20:06:54.993Z
Learning: For snapshotmanager/snapm follow-up requests from bmr-cymru, create a GitHub issue with label "enhancement", set/ensure a "type: Task" label, and assign it to bmr-cymru. Include backlinks to the PR and the discussion comment in the issue body.
Learnt from: bmr-cymru
Repo: snapshotmanager/snapm PR: 0
File: :0-0
Timestamp: 2025-09-14T02:14:30.316Z
Learning: PR #478 in snapshotmanager/snapm fixes a regression in the LVM2 plugin where `can_snapshot()` method throws `SnapmCalloutError` when probing non-device-mapper devices. The fix adds device major number validation to prevent calling dmsetup on non-dm devices, allowing proper "no provider found" error messages instead of confusing dmsetup errors.
📚 Learning: 2025-09-14T17:31:58.457Z
Learnt from: bmr-cymru
Repo: snapshotmanager/snapm PR: 478
File: snapm/manager/plugins/lvm2.py:512-518
Timestamp: 2025-09-14T17:31:58.457Z
Learning: In snapm, plugins are designed to fail loading when their required dependencies are missing (e.g., LVM2 plugin fails to load if device-mapper support is absent, Stratis plugin fails if D-Bus interfaces are missing). This is intentional behavior to ensure plugins only operate when all dependencies are available.

Applied to files:

  • doc/user_guide.rst
📚 Learning: 2025-09-14T02:14:30.316Z
Learnt from: bmr-cymru
Repo: snapshotmanager/snapm PR: 0
File: :0-0
Timestamp: 2025-09-14T02:14:30.316Z
Learning: PR #478 in snapshotmanager/snapm fixes a regression in the LVM2 plugin where `can_snapshot()` method throws `SnapmCalloutError` when probing non-device-mapper devices. The fix adds device major number validation to prevent calling dmsetup on non-dm devices, allowing proper "no provider found" error messages instead of confusing dmsetup errors.

Applied to files:

  • doc/user_guide.rst
  • snapm/manager/plugins/lvm2.py
📚 Learning: 2025-09-10T23:42:35.992Z
Learnt from: bmr-cymru
Repo: snapshotmanager/snapm PR: 357
File: snapm.spec:132-134
Timestamp: 2025-09-10T23:42:35.992Z
Learning: The snapm project maintainer bmr-cymru prefers scripted version bumping as part of the snapm-x.y.z-release-prep workflow rather than automated regex-based parsing for version synchronization across files.

Applied to files:

  • snapm/manager/plugins/lvm2.py
🧬 Code graph analysis (1)
tests/test_plugin.py (1)
snapm/manager/plugins/_plugin.py (1)
  • info (176-180)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (39)
  • GitHub Check: rpm-build:centos-stream-9-x86_64
  • GitHub Check: rpm-build:fedora-43-x86_64
  • GitHub Check: rpm-build:fedora-42-x86_64
  • GitHub Check: rpm-build:centos-stream-10-x86_64
  • GitHub Check: rpm-build:epel-9-x86_64
  • GitHub Check: rpm-build:fedora-rawhide-x86_64
  • GitHub Check: rpm-build:centos-stream-10-x86_64
  • GitHub Check: rpm-build:fedora-42-x86_64
  • GitHub Check: rpm-build:centos-stream-9-x86_64
  • GitHub Check: rpm-build:fedora-43-x86_64
  • GitHub Check: rpm-build:fedora-rawhide-x86_64
  • GitHub Check: rpm-build:epel-9-x86_64
  • GitHub Check: rpm-build:centos-stream-9-x86_64
  • GitHub Check: rpm-build:centos-stream-10-x86_64
  • GitHub Check: rpm-build:fedora-42-x86_64
  • GitHub Check: rpm-build:fedora-rawhide-x86_64
  • GitHub Check: rpm-build:epel-9-x86_64
  • GitHub Check: rpm-build:fedora-43-x86_64
  • GitHub Check: rpm-build:fedora-42-x86_64
  • GitHub Check: rpm-build:fedora-43-x86_64
  • GitHub Check: rpm-build:fedora-rawhide-x86_64
  • GitHub Check: rpm-build:centos-stream-10-x86_64
  • GitHub Check: rpm-build:epel-9-x86_64
  • GitHub Check: rpm-build:centos-stream-9-x86_64
  • GitHub Check: virt_tests (bios, lvm, fedora42)
  • GitHub Check: virt_tests (bios, lvm, fedora41)
  • GitHub Check: virt_tests (uefi, lvm, fedora41)
  • GitHub Check: virt_tests (bios, lvm-thin, centos-stream10)
  • GitHub Check: virt_tests (uefi, lvm, fedora42)
  • GitHub Check: virt_tests (uefi, lvm, centos-stream9)
  • GitHub Check: virt_tests (uefi, lvm-thin, centos-stream9)
  • GitHub Check: virt_tests (uefi, lvm, centos-stream10)
  • GitHub Check: virt_tests (bios, lvm-thin, centos-stream9)
  • GitHub Check: virt_tests (uefi, lvm-thin, centos-stream10)
  • GitHub Check: virt_tests (uefi, lvm-thin, fedora42)
  • GitHub Check: virt_tests (bios, lvm, centos-stream10)
  • GitHub Check: virt_tests (bios, lvm-thin, fedora42)
  • GitHub Check: virt_tests (bios, lvm, centos-stream9)
  • GitHub Check: python-basic-tests
🔇 Additional comments (7)
tests/test_plugin.py (1)

49-49: LGTM! Test expectation correctly updated.

The test expectation has been properly updated to match the new plugin version "0.2.0", aligning with the version bump in the Plugin base class.

doc/user_guide.rst (2)

1086-1088: LGTM! Documentation correctly updated.

The plugin version references have been properly updated to "0.2.0" for lvm2-cow, lvm2-thin, and stratis, aligning with the code changes across the PR.


1114-1116: LGTM! Priority override example correctly updated.

The version references in the overriding priority example have been properly updated to "0.2.0", maintaining consistency with the actual plugin implementations.

snapm/manager/plugins/_plugin.py (1)

118-118: LGTM! Base plugin version correctly updated.

The Plugin base class version has been properly bumped to "0.2.0" to reflect support for plugin priorities, aligning with the PR objectives and issue #853.

snapm/manager/plugins/lvm2.py (2)

1062-1062: LGTM! Lvm2Cow plugin version correctly updated.

The Lvm2Cow plugin version has been properly bumped to "0.2.0", consistent with the version bump across all plugins for priority support.


1376-1376: LGTM! Lvm2Thin plugin version correctly updated.

The Lvm2Thin plugin version has been properly bumped to "0.2.0", consistent with the version bump across all plugins for priority support.

snapm/manager/plugins/stratis.py (1)

439-439: LGTM! Stratis plugin version correctly updated.

The Stratis plugin version has been properly bumped to "0.2.0", completing the coordinated version bump across all snapshot provider plugins for priority support.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/snapshotmanager-snapm-876
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@bmr-cymru bmr-cymru merged commit 374dd79 into main Jan 2, 2026
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugins: bump plugin versions for prio support

2 participants