[Bug] Incorrect Type Hints

[sssaha]

The size property in DMC MODAL can be 55% - which is essentially a string. However the Type checker shows an warning if a string is provided

As this is the following definition:

size: typing.Optional[typing.Union[typing.Union[int, float, numbers.Number], Literal["xs"], Literal["sm"], Literal["md"], Literal["lg"], Literal["xl"]]] = None,

Same goes for the Title Component of Modal - the Title can be a DMC TITLE OR DMC Text - and not has to be a string component

[AnnMarieW]

Thanks for opening the issue @sssaha. There are quite a few props that have the wrong typehints. I'll change the description of the issue so it's more generic so we consolidate all of them here.

@AnnMarieW - I want to contribute - I do not know JS / TSX - but I can help with improving type hinting - is there any way I can help?

[AnnMarieW]

@sssaha1989 Thanks so much for the offer to help—I really appreciate it! I haven’t found a solution yet. The type hints are generated by Dash and depend on the types defined in the upstream Mantine library, so resolving this may require changes on the Dash side as well.

I’ll keep you posted as things progress, and I’m looking forward to collaborating with you on this!

Other issues found in DMC SEGMENTED control of how we define the data parameter

[AnnMarieW]

@sssaha can you check with dmc 1.2.0 and dash 3.0.4? It looks like the latest dash version fixed a lot of the typing issues.

@AnnMarieW - sorry for the delay on my end - it definitely got better. Some things I noticed (I will continue to add as I see)

• The size property in modal can be a string - like 85% - the typehint does not allow that
• The c property in dmc.Title - should not be a literal in my mind - people can use HTML color code or just other colors - in my mind it should be a string.

The data property in dmc.Select is not liking a list of dict.

The active property in dmc.Navlink - what are the allowable values? Is True and False still allowed? The typehint only includes exact or partial

[sssaha]

I just wanted to quickly check how can we resolve the issue - or we still have to wait for an upstream fix? Like for example the size property in dmc.Modal does not like if I provide "80%"

[AnnMarieW]

HI @sssaha
I just tried this with dash 4. There have been improvements in some of the props, for example the or | is handled correctly now. But Dash cannot handle Mantine's more complex types. For example size is defined like this:

 size?: MantineSize | (string & {}) | number;

The only thing dash can parse is the number. It may be necessary to update all the props with simpler types. For example

 size?: string | number;

It won't be very helpful, but at least there won't be type hint errors in the IDE.

---

Update

The Dash toolchain does not support string & {}, and there are no plans to support it in the near future. All those types in DMC need to be changed to string | number

[AnnMarieW]

Dash also doesn't support:

value?: [number, number];

Used in RangeSlider. The typehint error is:

Expected type 'tuple[SupportsFloat | SupportsInt | SupportsComplex, SupportsFloat | SupportsInt | SupportsComplex] | None', got 'list[int]' instead

I tried:

value?: number[]

But Mantine does not accept that:

TS2322: Type 'number[]' is not assignable to type 'RangeSliderValue'.
Target requires 2 element(s) but source may have fewer.