Conversation
Contributor
|
Sure I'm going to look at it |
jeremiegirault
approved these changes
Sep 20, 2017
| private extension Postal { | ||
|
|
||
| func doAsync<T, E: Error>(_ f: @escaping () throws -> T, completion: @escaping (Result<T, E>) -> Void) { | ||
| func doAsync<T, E>(_ f: @escaping () throws -> T, completion: @escaping (Result<T, E>) -> Void) { |
Contributor
There was a problem hiding this comment.
was it intended ? If so, I'm interested to know why ?
Contributor
Author
There was a problem hiding this comment.
It's to fix a warning Redundant conformance constraint 'E': 'Error'.
Contributor
There was a problem hiding this comment.
Because result already constraints E: Error ? Interesting, did not know that feature of swift 4. Thank you !
Contributor
Author
There was a problem hiding this comment.
Me neither, was surprised actually.
Contributor
There was a problem hiding this comment.
What's surprising is that it did not trigger in some other places, but we did not use a lot of generic constraints in Postal
Contributor
|
BTW I guess you can update the README badge for swift version :) |
Contributor
Author
|
Well I think we're good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jeremiegirault could you review if I missed something on this one please ?