Skip to content

feat: Support @attrs.frozen and @attrs.mutable#133

Merged
sondrelg merged 1 commit intosnok:mainfrom
ngnpope:feat/attrs-frozen-mutable
Sep 1, 2022
Merged

feat: Support @attrs.frozen and @attrs.mutable#133
sondrelg merged 1 commit intosnok:mainfrom
ngnpope:feat/attrs-frozen-mutable

Conversation

@ngnpope
Copy link
Copy Markdown
Contributor

@ngnpope ngnpope commented Sep 1, 2022

The attrs package has two additional decorators that are aliases for @attrs.define which should be included:

  • attrs.mutable() is an alias for attrs.define()
  • attrs.frozen() is an alias for define(frozen=True)

See https://www.attrs.org/en/stable/names.html#tl-dr

The `attrs` package has two additional decorators that are aliases for
`@attrs.define` which should be included:

- `attrs.mutable()` is an alias for `attrs.define()`
- `attrs.frozen()` is an alias for `define(frozen=True)`

See https://www.attrs.org/en/stable/names.html#tl-dr
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 1, 2022

Codecov Report

Merging #133 (d97a8af) into main (8e0d351) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #133   +/-   ##
=====================================
  Coverage   98.7%   98.7%           
=====================================
  Files          3       3           
  Lines        469     472    +3     
=====================================
+ Hits         463     466    +3     
  Misses         6       6           
Impacted Files Coverage Δ
flake8_type_checking/checker.py 98.5% <100.0%> (+<0.1%) ⬆️
flake8_type_checking/constants.py 100.0% <100.0%> (ø)

@sondrelg
Copy link
Copy Markdown
Member

sondrelg commented Sep 1, 2022

Lovely, thanks @ngnpope 👏

@sondrelg sondrelg merged commit 2163cd6 into snok:main Sep 1, 2022
@ngnpope ngnpope deleted the feat/attrs-frozen-mutable branch September 1, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants